Remove contrib/mac/{juliarc.jl,mac-gtk.sh} #35881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be removed. |
|
In fact the contrib directory is a bit of a misnomer. It mainly contains some utilities we need for the build, and scripts to build the installers. It could probably use a better name but changing it can be a bit of a chore. |
|
Yeah, I think we can just remove this file and anything referencing it. :) |
ViralBShah
added
building
Also remove a reference to contrib/mac/startup.jl from the main Makefile
fingolfin
force-pushed
the
mh/mac-startup.jl
branch
from
a570c23 to
8339aa9
Compare
|
I've update this PR to instead remove the file, and the reference to it in the |
|
The Mac failure doesn't look relevant. But someone else should take a look as well. |
|
I've started this build again. If it fails, can you rebase it on master? |
fingolfin
changed the title
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Also remove a reference to contrib/mac/startup.jl from the main Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is referenced by the main
Makefile; in commit88ad3ce references to juliarc.jl
where replaced by startup.jl everywhere, including the
Makefile;but this file here was not renamed.
That said, I don't know exactly why this might even be needed -- the fact that nobody noticed this issue for over two years suggest it might not be... So an alternative to this PR could be to remove this file, and code in
Makefilereferencingcontrib/mac/startup.jl.Looking at the logs, I think @staticfloat added it, so I am sure he'll now more :-)