Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS Notarization #35080

Merged

Conversation

staticfloat
Copy link
Member

We need to individually sign each Mach-O file independently, otherwise notarization bails. Note that you must sign the overall .app after each individual file is signed.

I've also added more Entitlements. I've gone for a "gentle shotgun" approach, turning on everything that I think we could reasonably want. I wait expectantly for someone to complain that they need Location access turned on for some package. ;)

We need to individually sign each Mach-O file independently, otherwise
notarization bails.  Note that you must sign the overall `.app` after
each individual file is signed.

I've also added more Entitlements.

I've gone for a "gentle shotgun" approach, turning on everything that I think
we could reasonably want.  I wait expectantly for someone to complain that
they need Location access turned on for some package.  ;)
@ararslan ararslan added the system:mac Affects only macOS label Mar 12, 2020
@Keno
Copy link
Member

Keno commented Mar 12, 2020

Do we know what entitlements e.g. Python asks for?

@staticfloat
Copy link
Member Author

The python launcher itself asks for the following two:

<key>com.apple.security.cs.disable-library-validation</key>
<true/>
<key>com.apple.security.cs.disable-executable-page-protection</key>
<true/>

The first so that it can load unsigned libraries (which we'd need as well) and the second I assume for some kind of JIT behavior.

@Keno
Copy link
Member

Keno commented Mar 12, 2020

All right, let's go with this for now then.

@staticfloat staticfloat merged commit 418f111 into master Mar 12, 2020
@staticfloat staticfloat deleted the sf/notarization_part_two_return_of_the_aftermath branch March 12, 2020 22:02
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
We need to individually sign each Mach-O file independently, otherwise
notarization bails.  Note that you must sign the overall `.app` after
each individual file is signed.

I've also added more Entitlements.

I've gone for a "gentle shotgun" approach, turning on everything that I think
we could reasonably want.  I wait expectantly for someone to complain that
they need Location access turned on for some package.  ;)
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
We need to individually sign each Mach-O file independently, otherwise
notarization bails.  Note that you must sign the overall `.app` after
each individual file is signed.

I've also added more Entitlements.

I've gone for a "gentle shotgun" approach, turning on everything that I think
we could reasonably want.  I wait expectantly for someone to complain that
they need Location access turned on for some package.  ;)
@staticfloat
Copy link
Member Author

This should be backported in case we ever do a 1.4.2

KristofferC pushed a commit that referenced this pull request May 10, 2020
We need to individually sign each Mach-O file independently, otherwise
notarization bails.  Note that you must sign the overall `.app` after
each individual file is signed.

I've also added more Entitlements.

I've gone for a "gentle shotgun" approach, turning on everything that I think
we could reasonably want.  I wait expectantly for someone to complain that
they need Location access turned on for some package.  ;)

(cherry picked from commit 418f111)
@KristofferC KristofferC mentioned this pull request May 10, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants