Optimize image sizes #34724
Merged
Optimize image sizes #34724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice little improvement. Does anyone know what the concerns might be if any? Pinging @cormullion |
|
Might be a good idea to run it on the julialang website repo too. |
|
Seems like a good idea - these aren't the masters anyway. Is this bunch of files used: If so, they're out of date - showing the older Julia logo style with dark edges... |
|
Given that we now have the logos in their own repo, it might be a good idea to just get rid of them from contrib, except for the ones that are needed in the installers. |
|
Anyway that framework stuff was PR #31914 that is still pending/non-merged. I'd suggest leaving them as they are, and re-visiting if the PR is ever merged... |
|
I'll fork JuliaLang/www.julialang.org and do the same there. I'll just wait for the conclusions on the rest of the concerns here before I do anything on this side. 🙂 |
|
Fewer concerns on the www.julialang.org side. I think we'll just merge there. Here, we'll leave it open just another day or two. |
|
Is this using the default |
|
@mbauman It is, yes. |
|
@ViralBShah Any news on this? |
*Total -- 454.15kb -> 369.09kb (18.73%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 93.13kb -> 62.33kb (33.07%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 39.53kb -> 27.93kb (29.36%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/512.png -- 37.95kb -> 27.92kb (26.42%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 16.51kb -> 12.56kb (23.94%) /doc/images/github_metadata_develbranch.png -- 64.04kb -> 49.36kb (22.92%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/256.png -- 15.88kb -> 12.70kb (20.02%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/128.png -- 7.12kb -> 5.73kb (19.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 3.29kb -> 2.68kb (18.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 1.43kb -> 1.25kb (13.14%) /doc/images/github_metadata_pullrequest.png -- 36.66kb -> 31.91kb (12.94%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/32.png -- 1.44kb -> 1.26kb (12.27%) /doc/images/jltypes.svg -- 120.36kb -> 116.92kb (2.86%) /doc/src/assets/logo-dark.svg -- 6.82kb -> 6.69kb (1.92%) /doc/src/assets/logo.svg -- 6.81kb -> 6.69kb (1.84%) /contrib/julia.svg -- 3.19kb -> 3.18kb (0.15%) Signed-off-by: ImgBotApp <[email protected]>
pthariensflame
force-pushed
the
improvement/imgbot
branch
from
bf56ada to
81920db
Compare
|
Good to merge. |
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
*Total -- 454.15kb -> 369.09kb (18.73%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 93.13kb -> 62.33kb (33.07%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 39.53kb -> 27.93kb (29.36%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/512.png -- 37.95kb -> 27.92kb (26.42%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 16.51kb -> 12.56kb (23.94%) /doc/images/github_metadata_develbranch.png -- 64.04kb -> 49.36kb (22.92%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/256.png -- 15.88kb -> 12.70kb (20.02%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/128.png -- 7.12kb -> 5.73kb (19.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 3.29kb -> 2.68kb (18.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 1.43kb -> 1.25kb (13.14%) /doc/images/github_metadata_pullrequest.png -- 36.66kb -> 31.91kb (12.94%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/32.png -- 1.44kb -> 1.26kb (12.27%) /doc/images/jltypes.svg -- 120.36kb -> 116.92kb (2.86%) /doc/src/assets/logo-dark.svg -- 6.82kb -> 6.69kb (1.92%) /doc/src/assets/logo.svg -- 6.81kb -> 6.69kb (1.84%) /contrib/julia.svg -- 3.19kb -> 3.18kb (0.15%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: Imgbot <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
*Total -- 454.15kb -> 369.09kb (18.73%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 93.13kb -> 62.33kb (33.07%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 39.53kb -> 27.93kb (29.36%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/512.png -- 37.95kb -> 27.92kb (26.42%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 16.51kb -> 12.56kb (23.94%) /doc/images/github_metadata_develbranch.png -- 64.04kb -> 49.36kb (22.92%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/256.png -- 15.88kb -> 12.70kb (20.02%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/128.png -- 7.12kb -> 5.73kb (19.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 3.29kb -> 2.68kb (18.56%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/[email protected] -- 1.43kb -> 1.25kb (13.14%) /doc/images/github_metadata_pullrequest.png -- 36.66kb -> 31.91kb (12.94%) /contrib/mac/frameworkapp/JuliaLauncher/Assets.xcassets/AppIcon.appiconset/32.png -- 1.44kb -> 1.26kb (12.27%) /doc/images/jltypes.svg -- 120.36kb -> 116.92kb (2.86%) /doc/src/assets/logo-dark.svg -- 6.82kb -> 6.69kb (1.92%) /doc/src/assets/logo.svg -- 6.81kb -> 6.69kb (1.84%) /contrib/julia.svg -- 3.19kb -> 3.18kb (0.15%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: Imgbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by ImgBot on my own fork, which I then immediately merged and turned into this manual pull request.
Below is reproduced ImgBot's own message on the content of this PR.