macOS codesigning: only attempt if $MACOS_CODESIGN_IDENTITY is set
#33228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
added
backport 1.0
building
Keno
approved these changes
Sep 11, 2019
|
Will address #33141 in the future |
staticfloat
force-pushed
the
sf/parameterized_codesigning
branch
2 times, most recently
from
8b89956 to
c899e9d
Compare
This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build
staticfloat
force-pushed
the
sf/parameterized_codesigning
branch
from
c899e9d to
1ddcd23
Compare
KristofferC
pushed a commit
that referenced
this pull request
Sep 18, 2019
…33228) This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build (cherry picked from commit 0760842)
18 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 19, 2019
…33228) This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build (cherry picked from commit 0760842)
KristofferC
pushed a commit
that referenced
this pull request
Dec 3, 2019
…33228) This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build (cherry picked from commit 0760842)
56 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
…33228) This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build (cherry picked from commit 0760842)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
…33228) This has the following advantages: * It allows our buildbots to pass in which code signing identity they want to use (rather than having the identity hash hardcoded in our build system) * It stops blindly attempting to codesign on random user's machines * It causes codesign failure to stop the build (cherry picked from commit 0760842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the following advantages:
It allows our buildbots to pass in which code signing identity they
want to use (rather than having the identity hash hardcoded in our build
system)
It stops blindly attempting to codesign on random user's machines
It causes codesign failure to stop the build