Codecov Report

Base: 91.52% // Head: 91.17% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (04d5038) compared to base (6c8849b).
Patch coverage: 66.66% of modified lines in pull request are covered.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   91.52%   91.17%   -0.35%     
==========================================
  Files           3        3              
  Lines         118      136      +18     
==========================================
+ Hits          108      124      +16     
- Misses         10       12       +2     

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Thanks, these changes look good to me at first glance! You'll need to do a rebase/merge of master- also feel free to bump the project to 1.2.0 (otherwise I will after merge).

No tests for now: could you please help with adding these coords to generated tables in test/data?

I will take a look!

@aplavin you should be able to add some tests for Ecliptic coordinates in the test/astropy.jl files once you rebase off master!

Thanks for setting tests up, @mileslucas!

Currently, these ecliptic coords seem to be approximate: results are close to astropy (tests pass for 1e-3 tol), but not exactly equal. I guess some small extra rotation isn't accounted for...

For me, ecliptic coords with this accuracy are fine. More precise conversion may require extra distinct types anyway, as astropy does: geo/helio/bary centric, mean/true.