Add offset function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 96.22% 99.13% +2.91%
==========================================
Files 2 2
Lines 106 116 +10
==========================================
+ Hits 102 115 +13
+ Misses 4 1 -3
Continue to review full report at Codecov.
|
giordano
approved these changes
Apr 14, 2020
| @@ -1,7 +1,7 @@ | |||
| name = "SkyCoords" | |||
| uuid = "fc659fc5-75a3-5475-a2ea-3da92c065361" | |||
| authors = "Kyle Barbary, Mosé Giordano, and contributors" | |||
| version = "0.5.0" | |||
| version = "0.6.0" | |||
There was a problem hiding this comment.
I'd go to v1.0 at this point. The main API is quite stable, we usually only add new features
There was a problem hiding this comment.
Hm, I disagree. I think #6 needs to be decided on, since it could change the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two functions called
offset. The first takes a coordinate, separation in rad, and position angle in rad and returns another coordinate. This is equivalent to theSkyCoord.directional_offset_bymethod. The other version takes two sky coordinates and returns a tuple of the separation and position angle.Docs have been added, along with tests for accuracy, type stability, and integration (finding the offset between two coords and then offsetting one should return the other). Doc preview should show up at https://juliaastro.github.io/SkyCoords.jl/previews/PR34.
I've also bumped package version to
0.6.0so we can release after this is merged.