Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position angle #32

Merged
merged 3 commits into from
Mar 25, 2020
Merged

position angle #32

merged 3 commits into from
Mar 25, 2020

Conversation

mileslucas
Copy link
Member

Adds position_angle for getting the position angle between two coordinates.

@mileslucas mileslucas requested a review from giordano March 16, 2020 10:39
src/SkyCoords.jl Outdated Show resolved Hide resolved
src/SkyCoords.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@mileslucas
Copy link
Member Author

Argh I keep forgetting to turn my autoformatter off for PRs. Let me try this again.

@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #32 into master will increase coverage by 3.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   92.55%   96.22%   +3.67%     
==========================================
  Files           2        2              
  Lines          94      106      +12     
==========================================
+ Hits           87      102      +15     
+ Misses          7        4       -3     
Impacted Files Coverage Δ
src/SkyCoords.jl 97.59% <100.00%> (+3.22%) ⬆️
src/types.jl 91.30% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d19bd...c07f7f0. Read the comment docs.

@mileslucas
Copy link
Member Author

@giordano ready for review again.

@giordano giordano merged commit 27b4ece into JuliaAstro:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants