String Construction #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 86.36% 92.55% +6.18%
==========================================
Files 2 2
Lines 66 94 +28
==========================================
+ Hits 57 87 +30
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
giordano
reviewed
Dec 5, 2019
|
Not sure whats causing the 1.0 failure on the most recent builds. I'll investigate it further. |
|
Previous failures were due to |
giordano
reviewed
Dec 6, 2019
|
Good catch on the docstring, I forgot to test that. |
giordano
reviewed
Jan 6, 2020
| @test C("12h 0.0m 0.0s", "90:0:0") == C(π, π / 2) | ||
| @test C("18h0:0", "90:0:0") == C(3π / 2, π / 2) | ||
| if C == GalCoords | ||
| @test C("12:0:0", "90:0:0") == C(0.20943951023931956, π / 2) |
There was a problem hiding this comment.
It's a bit unfortunate that
julia> deg2rad(12)
0.20943951023931956instead of giving
julia> pi / 15
0.20943951023931953
but there is little we can do here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality for constructing coordinates using strings. It is driven by the new
str2radfunction.str2rad
There are two base regex patterns to arbitrarily parse the string as either a degree or an hour angle. In addition there is a boolean flag to force parse the string as an hour angle. Here is a clip of the documentation I've written for it
(If it's not clear, the other ticks that aren't quotation marks are
\primeand\pprime, which are what unitful uses for its arcminutes and arcseconds).string construction
The string construction takes all the types and adds a signature like
Coord(::AbstractString, ::AbstractString). For coordinates that use RA (ICRS and FK5) the first string will be force-parsed as an hour angle. Here is an example of the usageversion
bump to
0.5.0to prep for release