Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated Base.Test to Test #47

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Change deprecated Base.Test to Test #47

merged 2 commits into from
Oct 16, 2017

Conversation

TestSubjector
Copy link
Contributor

@giordano
Copy link
Member

This works only on Julia master. We should either use this trick or resort to Compat.jl package, in particular using Compat.Test.

@TestSubjector
Copy link
Contributor Author

I'm leaning more towards the first option, even though it's a bit more verbose. Update PR?

@giordano
Copy link
Member

Yes, I also prefer the first option unless we need to use Compat more extensively.

Yes, please, update this PR ☺️

@giordano giordano merged commit 1ec83cc into JuliaAstro:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TestSubjector @giordano