Fix Repo extraction in regex #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanCrg90
force-pushed
the
fix_repo_extraction_in_regex
branch
from
86b9bcb
to
a5409da
Compare
I noticed that repositories that ends en i or t failed, this updates the regex to support the expected values and adds some tests, we could consider to extract the regex to its own module for isolation but I think its too much considering is only used here for remote parsing.
JuanCrg90
force-pushed
the
fix_repo_extraction_in_regex
branch
from
a5409da
to
0cf94b9
Compare
JuanCrg90
force-pushed
the
fix_repo_extraction_in_regex
branch
2 times, most recently
from
65abdff
to
28083a6
Compare
JuanCrg90
force-pushed
the
fix_repo_extraction_in_regex
branch
from
28083a6
to
6ef6510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that repositories that ends en i or t failed, this updates the regex to support the expected values and adds some tests, we could consider to extract the regex to its own module for isolation but I think its too much considering is only used here for remote parsing.