Add ability to create File objects from existing files (#11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonxslays
requested changes
Dec 30, 2021
|
Leaving this here for reference: type LoadResult<T> = Result<T, LoadError>;
#[derive(Debug, Clone)]
pub struct LoadError {
message: String,
}
impl LoadError {
fn new(message: &str) -> Self {
Self {
message: message.into(),
}
}
}
impl std::fmt::Display for LoadError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "{}", self.message)
}
} |
Jonxslays
reviewed
Dec 30, 2021
Jonxslays
reviewed
Dec 30, 2021
|
Anything marked as resolved I've done locally, but may not have pushed yet. |
parafoxia
force-pushed
the
master
branch
2 times, most recently
from
a22693c
to
de44d4a
Compare
Jonxslays
approved these changes
Dec 31, 2021
parafoxia
added a commit
to parafoxia/piston_rspy
that referenced
this pull request
Apr 13, 2022
Jonxslays
pushed a commit
to parafoxia/piston_rspy
that referenced
this pull request
Jun 30, 2022
Jonxslays
added a commit
to Jonxslays/piston_rspy
that referenced
this pull request
Jun 30, 2022
* Add bindings for features added in Jonxslays/piston_rs#12 * Fix typo * Add load_from and load_content_from method impls Co-authored-by: Jonxslays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
load_fromclassmethod and theload_contents_frommethod to load contents from existing files (it also adds a privateload_contentsmethod which the two public methods share)Closes #11.