Remove atomic setter transformers #428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of `afterReflectiveSetter` Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
|
@eupp, do we have tests checking that the local object detection works correctly with updates via methods like |
Apparently, there are tests for AFU, Unsafe, and VarHandle APIs, but it looks like there are no tests for Atomics and Atomic Arrays. I can add them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove separate bytecode transformers which tracked methods like
.set,.compareAndSet, etc, ofVarHandle,AFU, andUnsafeAPIs, to inform theObjectTrackerabout changes in object graph topology (registerObjectLinklistener).Instead, modify
ManagedStrategy::beforeMethodCallto parse the method name and arguments to extract relevant information and pass it intoObjectTracker.Also, it looks like the new approach is more robust and handles more cases, which were not handled previously (e.g. atomic array APIs). As such, there are changes in some
representationtests --- the reported traces now include more events, which were previously incorrectly classified as local object accesses.