Make it optional for parameter names to match named generators #360
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if parameter names were enabled at compile-time, all parameters were required to match a named generator. This made including parameter names, and using Lincheck with languages always enabling parameter names like Scala, impractical. This instead makes it optional, such that if a named generator matches it is used but if none is found then we apply a default generator. This also enables parameter names at compile time for tests in order to test this behavior.
mpdncrwd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if parameter names were enabled at compile-time, all parameters were required to match a named generator. This made including parameter names and using Lincheck with languages always enabling parameter names, like Scala, impractical. This PR:
javaParameterswhen compiling tests in order to include parameter names - this makes all tests fail