Object numeration mismatch fix #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkoval
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Hi @avpotapov00! I've reviewed the PR and left some comments. Could you please also rebase it onto the current develop?
| | | atomicReference1.READ: AtomicReference#1 at AtomicReferencesFromMultipleFieldsTest.actionsForTrace(AtomicReferencesNamesTests.kt:97) | | ||
| | | atomicReference2.READ: AtomicReference#1 at AtomicReferencesFromMultipleFieldsTest.actionsForTrace(AtomicReferencesNamesTests.kt:97) | | ||
| | | AtomicReference#1.get(): Node#2 at AtomicReferencesFromMultipleFieldsTest.actionsForTrace(AtomicReferencesNamesTests.kt:97) | | ||
| | | AtomicReference#1.compareAndSet(Node#2,Node#3): true at AtomicReferencesFromMultipleFieldsTest.actionsForTrace(AtomicReferencesNamesTests.kt:97) | |
There was a problem hiding this comment.
Is there any difference in this output besides the line numbers?
| @@ -231,7 +231,9 @@ internal fun GeneratorAdapter.invokeBeforeEvent(debugMessage: String, setMethodE | |||
| push(debugMessage) | |||
| invokeStatic(Injections::beforeEvent) | |||
| }, | |||
| elseClause = {} | |||
| elseClause = { | |||
| invokeStatic(Injections::enumerateObjectsIfNeeded) | |||
There was a problem hiding this comment.
This logic contradicts with the invokeBeforeEvent function name
| @@ -10,12 +10,12 @@ The following interleaving leads to the error: | |||
| | Thread 1 | Thread 2 | | |||
| | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | | enqueue(-1) | | |||
| | | q.enqueue(-1) at ObstructionFreedomViolationEventsCutTest.enqueue(SpinlockEventsCutTests.kt:34) | | |||
| | | q.enqueue(-1) at ObstructionFreedomViolationEventsCutTest.enqueue(SpinlockEventsCutTests.kt:33) | | |||
There was a problem hiding this comment.
Is there any difference besides the line numbers? Please check other outputs as well.
|
@avpotapov00 could you please rebase the PR onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #343