Ensure cookies aren't sent if credentials: omit
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the default value of `withCredentials` is `true`, as opposed to `false`, the library will send the cookies even if `credentials: omit` is specified. This affects React Native where the default value is `true` since cross-origin concerns don't apply.
|
Yes, we very much need this for React Native's Thank you @satya164! |
|
Makes sense; thanks! |
|
Just ran into this issue in React Native. Could you please publish a new version of this package with this fix? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default value of
withCredentialsistrue, as opposed tofalse, the library will send the cookies even ifcredentials: omitis specified. This affects React Native where the default value istruesince cross-origin concerns don't apply.