Handle cases where `self` isn't defined #253

billinghamj · 2016-01-06T12:19:28Z

Resolves #252, #238, #165, #125, #124, and probably a few others.

There are a lot of different ways this code could be written. If you have style preferences contrary to the way I've done this, I'd be very happy to change it.

mislav · 2016-01-09T11:53:27Z

Looks good!

@dgraham Any objections?

dgraham · 2016-01-09T17:04:29Z

Invoking the wrapper function with this resolves to window, which is how we started all the way back in c1af6de. This looks good to me.

chrisirhc · 2016-01-10T05:18:27Z

Wouldn't this still throw a ReferenceError exception where self isn't defined? How about doing a typeof check like typeof self !== 'undefined' ? self : this ?

mislav · 2016-01-10T13:29:14Z

Good point @chrisirhc. Someone should test this out in an isomorphic environment and report back. I have no idea how it would handle the self || this construct.

billinghamj · 2016-01-10T18:30:36Z

Hmm, yes that is true. Another option could be:

this.self || this

Which works exactly the same way but should not throw.

billinghamj · 2016-01-11T12:26:35Z

I have updated the code as per the above comment.

mislav · 2016-01-11T16:14:19Z

Can someone test this out in an isomorphic environment, as per people's complaints on aforementioned threads?

billinghamj · 2016-01-11T17:24:44Z

Node - master branch:

$ node
> var a = require('./fetch')
ReferenceError: self is not defined
    at /Users/james/Projects/fetch/fetch.js:4:7
    at Object.<anonymous> (/Users/james/Projects/fetch/fetch.js:381:3)
    at Module._compile (module.js:398:26)
    at Object.Module._extensions..js (module.js:405:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at repl:1:9
    at REPLServer.defaultEval (repl.js:254:27)

Node - this PR:

$ node
> var a = require('./fetch')
undefined
> a
{ Headers: [Function: Headers],
  Request: [Function: Request],
  Response: { [Function: Response] error: [Function], redirect: [Function] },
  fetch: { [Function] polyfill: true } }

React Native - master
React Native - this PR (this new error is a separate issue from isomorphic-fetch)

I can't speak for other environments though

Similar to JakeChampion/fetch#253

mislav · 2016-01-15T01:54:57Z

fetch.js

@@ -378,4 +378,4 @@
    })
  }
  self.fetch.polyfill = true
-})();
+})(this.self || this);


I feel like I would like to revert to @chrisirhc's idea by doing

typeof self !== 'undefined' ? self : this

simply because that approach has been better battle-tested by compilers such as Browserify.

billinghamj · 2016-01-18T17:12:20Z

@mislav updated as-per your comment

Handle cases where `self` isn't defined

mislav · 2016-01-19T00:24:56Z

Thank you!

yorkie · 2016-01-19T04:44:32Z

Hey @mislav did you forget to publish to npm, when I install 0.11.0 get the following:

pm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "i"
npm ERR! node v5.0.0
npm ERR! npm  v3.3.6

npm ERR! No compatible version found: [email protected]
npm ERR! Valid install targets:
npm ERR! ["0.10.1","0.10.0","0.9.0","0.8.2","0.8.1","0.8.0","0.7.0","0.6.1","0.6.0","0.5.0"]
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/yorkieliu/workspace/weflex/gian/npm-debug.log

mislav · 2016-01-19T05:29:24Z

@yorkie Something's wrong with our build system and auto-publish on npm. Stay tuned.

yorkie · 2016-01-19T05:38:27Z

I see, is there something I can help? This is no hurry, but if we can get a working notification with npm, that would be so sweet :-)

mislav · 2016-01-19T05:39:21Z

I just did a manual `npm publish` for now.

yorkie · 2016-01-19T05:59:18Z

It's working now, very thanks to you @mislav 👍

billinghamj force-pushed the polyfill-self branch from 9045eec to 504e4a4 Compare January 11, 2016 12:25

billinghamj added a commit to billinghamj/isomorphic-fetch that referenced this pull request Jan 11, 2016

Handle cases where self doesn't exist

d405743

Similar to JakeChampion/fetch#253

billinghamj mentioned this pull request Jan 11, 2016

Handle cases where self doesn't exist matthew-andrews/isomorphic-fetch#63

Closed

billinghamj added a commit to billinghamj/isomorphic-fetch that referenced this pull request Jan 11, 2016

Handle cases where self doesn't exist

3bc3f21

Similar to JakeChampion/fetch#253

mislav reviewed Jan 15, 2016
View reviewed changes

Handle cases where self isn't defined

ad009dc

billinghamj force-pushed the polyfill-self branch from 504e4a4 to ad009dc Compare January 18, 2016 17:05

mislav added a commit that referenced this pull request Jan 19, 2016

Merge pull request #253 from billinghamj/polyfill-self

f4fc29f

Handle cases where `self` isn't defined

mislav merged commit f4fc29f into JakeChampion:master Jan 19, 2016

billinghamj deleted the polyfill-self branch January 19, 2016 10:38

billinghamj mentioned this pull request Jan 30, 2016

Getting referenceerror: self is not defined when running mocha tests in command line as soon as I attempt to use isomorphic-fetch matthew-andrews/isomorphic-fetch#59

Open

randallknutson mentioned this pull request Aug 16, 2016

Server side rendering formio/react#65

Closed

randallknutson added a commit to formio/formio.js that referenced this pull request Aug 16, 2016

Update dependency on whatwg-fetch to solve JakeChampion/fetch#253

5dc0440

mansona mentioned this pull request Nov 10, 2016

moving from isomorphic-fetch to fetch-everywhere redux-json-api/redux-json-api#91

Merged

Connorelsea mentioned this pull request Mar 6, 2017

Add support for React Native, remove and replace isomorphic-fetch agraboso/redux-api-middleware#119

Closed

tqc mentioned this pull request May 17, 2017

Add additional fallbacks when self is undefined #521

Closed

jungdj mentioned this pull request Jun 25, 2020

"self is not defined" error in React after upgrading to 3.0.0 #657

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle cases where `self` isn't defined #253

Handle cases where `self` isn't defined #253

billinghamj commented Jan 6, 2016

mislav commented Jan 9, 2016

dgraham commented Jan 9, 2016

chrisirhc commented Jan 10, 2016

mislav commented Jan 10, 2016

billinghamj commented Jan 10, 2016

billinghamj commented Jan 11, 2016

mislav commented Jan 11, 2016

billinghamj commented Jan 11, 2016

mislav Jan 15, 2016

billinghamj commented Jan 18, 2016

mislav commented Jan 19, 2016

yorkie commented Jan 19, 2016

mislav commented Jan 19, 2016

yorkie commented Jan 19, 2016

mislav commented Jan 19, 2016 via email

yorkie commented Jan 19, 2016

Handle cases where self isn't defined #253

Handle cases where self isn't defined #253

Conversation

billinghamj commented Jan 6, 2016

mislav commented Jan 9, 2016

dgraham commented Jan 9, 2016

chrisirhc commented Jan 10, 2016

mislav commented Jan 10, 2016

billinghamj commented Jan 10, 2016

billinghamj commented Jan 11, 2016

mislav commented Jan 11, 2016

billinghamj commented Jan 11, 2016

mislav Jan 15, 2016

Choose a reason for hiding this comment

billinghamj commented Jan 18, 2016

mislav commented Jan 19, 2016

yorkie commented Jan 19, 2016

mislav commented Jan 19, 2016

yorkie commented Jan 19, 2016

mislav commented Jan 19, 2016 via email

yorkie commented Jan 19, 2016

Handle cases where `self` isn't defined #253

Handle cases where `self` isn't defined #253