Reject the Promise returned by fetch() when Request ctor throws #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -601,8 +609,7 @@ suite('Methods', function() { | |||
| }) | |||
| }) | |||
|
|
|||
| // TODO: Waiting to verify behavior | |||
There was a problem hiding this comment.
Is this change OK? I'm not sure what this TODO was for, but as far as I can tell the tests appear correct and inline with the spec and current implementations. I needed to enable them to verify that the Request constructor throws under the same conditions I'm using to verify that fetch() rejects.
There was a problem hiding this comment.
Yeah, right now the Chrome implementation also throws an exception on GET/HEAD with body. There is a suggestion to change the spec to allow bodies for GET requests, but until the spec actually changes, I think these tests are good.
|
Looks good! |
mislav
added a commit
that referenced
this pull request
Oct 10, 2015
Reject the Promise returned by fetch() when Request ctor throws
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves part of what #132 does, but that PR seems abandoned.
https://fetch.spec.whatwg.org/#dom-global-fetch step 2 states that exceptions thrown by the Request constructor should cause fetch() to reject with the error. Exceptions thrown synchronously in the Promise callback will cause a rejection, so I've simply moved the Request ctor call into the Promise callback.
Manually verified that tests pass with native fetch implementations in Chrome and Firefox.