Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis #12

Merged
merged 1 commit into from
Oct 15, 2014
Merged

Travis #12

merged 1 commit into from
Oct 15, 2014

Conversation

josh
Copy link
Contributor

@josh josh commented Oct 15, 2014

Having trouble with regular tests, but trying to get the linting going first.

Closes #11.

@dgraham
Copy link
Contributor

dgraham commented Oct 15, 2014

There are a couple lint errors that I didn't know how to turn off. It doesn't like catch being a Promise method and a JS keyword.

@josh
Copy link
Contributor Author

josh commented Oct 15, 2014

It doesn't like catch being a Promise method and a JS keyword.

We really should fix those. Otherwise ES3 browsers are going to barf parsing the file.

@josh
Copy link
Contributor Author

josh commented Oct 15, 2014

One sec, I think travis wants the file in master to setup.

@dgraham
Copy link
Contributor

dgraham commented Oct 15, 2014

It's working fine in production.

josh added a commit that referenced this pull request Oct 15, 2014
@josh josh merged commit aa2fa4d into master Oct 15, 2014
@josh josh deleted the travis branch October 15, 2014 22:16
@josh
Copy link
Contributor Author

josh commented Oct 15, 2014

It's working fine in production.

Anytime we use catch in Coffeescript it rewrites it as not a reversed symbol.

promise.catch (err) -> console.error err
promise["catch"](function(err) {
  return console.error(err);
});

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis
2 participants