Skip to content

SwiftGen 6.5.1 #86446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djbe wants to merge 5 commits into from
Closed

SwiftGen 6.5.1 #86446

djbe wants to merge 5 commits into from

Conversation

@djbe
Copy link
Contributor

@djbe djbe commented Oct 4, 2021 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Quick bug fix release. It also now only builds the active architecture (instead of universal builds).

@BrewTestBot BrewTestBot added macos-only Formula depends on macOS ruby Ruby use is a significant feature of the PR or issue labels Oct 4, 2021
@djbe
Copy link
Contributor Author

djbe commented Oct 4, 2021 •
edited
Loading

So, removing universal builds actually broke our binary (in Homebrew)... For some reason after installing it in libexec and symlink'ing into bin:

  • a NON-universal build will search for it's bundle in bin (see test error on CI)
  • a (thinned) universal build will search in libexec as expected
  • The NON-universal build works if I invoke it directly in libexec or install everything in bin

For now, I've gone back to building universal builds and thinning them with deuniversalize_machos.

Update (from threaded discussions below): a shim (script) works instead of a symlink.

@djbe djbe changed the title swiftgen 6.5.1 SwiftGen 6.5.1 Oct 4, 2021
carlocab
carlocab reviewed Oct 5, 2021
View reviewed changes
carlocab
carlocab reviewed Oct 5, 2021
View reviewed changes
@djbe djbe mentioned this pull request Oct 6, 2021
Merged
carlocab
carlocab approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @djbe! Nice work.

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Oct 6, 2021

🤖 A scheduled task has triggered a merge.

@djbe djbe deleted the swiftgen-6.5.1 branch October 6, 2021 11:30
@djbe djbe mentioned this pull request Oct 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

macos-only Formula depends on macOS ruby Ruby use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djbe @BrewTestBot @carlocab