-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
SwiftGen 6.5.0 #86408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftGen 6.5.0 #86408
Conversation
|
Seems like there are 2 issues:
The second one is kinda minor, it's weird that only The first one is a much bigger issue. This is how SPM binaries with resources work, we're not allowed to move those bundles to another place, it'll break the path of |
ARM was being skipped, I've added the
We can try the following: diff --git a/Formula/swiftgen.rb b/Formula/swiftgen.rb
index 7f200071516..d8ec22ade49 100644
--- a/Formula/swiftgen.rb
+++ b/Formula/swiftgen.rb
@@ -53,6 +53,9 @@ class Swiftgen < Formula
"#{fixtures}/Generated/XCAssets/swift5/all.swift" => "xcassets.swift",
"#{fixtures}/Generated/YAML/inline-swift5/all.swift" => "yaml.swift",
})
+
+ # Replace universal binaries with their native slices
+ deuniversalize_machos
end
test do
Sorry, I'm honestly not sure. I'll let others chime in here. |
|
Passing a flag to the build to build only native binaries would be preferable to using Re the location of |
|
I've updated the formula to install in For now I'm also using |
|
Nice the checks pass now 🎉 Any thoughts on the |
|
The default branch is |
|
The homebrew documentation mentions that My issue is that
Note: homebrew version info
|
@nandahkrishna, thoughts here? (I think you implemented this audit -- apologies if I'm misremembering.) |
|
From the git history for the formula, seems like @chenrui333 made the change to |
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Release of SwiftGen/SwiftGen#881
brew audit --strict --online swiftgendoesn't want to work, it keeps complaining about:Once I set it to
stable, the audit passes. The problem is, our "head" branch isdevelop, notstable. In our last release we set it todevelop, but someone else changed the formula to point atstablefor some reason.