Description

New Subtitle Rules Panel (#1860)

This provides a more flexible set of options for automatically adding subtitle tracks when importing a source into HandBrake.

Would appreciate some feedback on the UX of the new panel design.

I've dropped the Add CC when available option. it seems redundant.

Preset Format Changes:

The new preset format is as follows:

We can probably migrate the format forward to a limited degree when the mac and linux Ui's update as well.

        "SubtitleBehaviours": [
            {
              "IsoLangCode": "eng",
              "TrackSelectionMode": 0,
              "DefaultMode": 0,
              "BurnPassthruMode": 0,
              "ForcedMode": 0,
              "TrackNameOverride": "Test",
              "IsForeignAudioScanRule": 1
            },
            {
              "IsoLangCode": "fra",
              "TrackSelectionMode": 1,
              "DefaultMode": 1,
              "BurnPassthruMode": 1,
              "ForcedMode": 0,
              "TrackNameOverride": "Test 2",
              "IsForeignAudioScanRule": 0
            },
            {
              "IsoLangCode": "deu",
              "TrackSelectionMode": 0,
              "DefaultMode": 0,
              "BurnPassthruMode": 2,
              "ForcedMode": 0,
              "TrackNameOverride": "Test 3",
              "IsForeignAudioScanRule": 0
            }
          ],
          "SubtitleUseSourceOrder": true,
          "SubtitleImportMode": 0,
          "SubtitlePassthruTrackNames": true,

Removed Preset Keys

File Loading Notes

When an import mode is selected, any file that has the extension .srt or .ssa that also contains the source filename (case insensitive) will be imported.

We try to guess the language of the file by:

• Checking if the file contains the english or native name.
• Checking if it contains an iso code i.e ".eng." (Note the "."'s. These are to help avoid false positives by using this common convention in the filenames.

Screenshots

Command Line

I think we leave it as-is. Trying to implement advanced options as CLI params is pretty ugly. Where users are using a preset, they'd gain the more complex behaviour by virtue of the shared preset code I believe.

TODO

1. presets.c needs updated with new logic.
2. macOS GUI needs updated
3. Linux GUI needs updated
4. Decide what to do with HandBrakeCLI.exe