Skip to content

Conversation

@galad87
Copy link
Contributor

@galad87 galad87 commented Dec 19, 2023

Converts the frames to the pixel format required by the encoder. Should fix #5606
If someone with an NVIDIA GPU could test it.

Tested on:

  • Windows 10+ (via MinGW)
  • macOS 10.13+
  • Ubuntu Linux

@sr55
Copy link
Contributor

sr55 commented Feb 12, 2024

10Bit Source

NVEnc HEVC 10-bit
No Scaling: https://gist.github.com/sr55/228b827a3f7a7e722234eb47802e6996 (Hardware Decode)
Downscaling to 1080p https://gist.github.com/sr55/bdaf914b2dcf8fa2b703bf3923bdbba8 (Software Decode)

NVEnc HEVC 8-bit
No Scaling -> Encode Failed https://gist.github.com/sr55/2ea15bb200d08816f223f1a024d2ad3b (Software Decode)
Downcale to 1080p OK https://gist.github.com/sr55/72ddf243f54ecc39b67eeab1903f8832 (Software Decode)

@sr55
Copy link
Contributor

sr55 commented Feb 12, 2024

8 Bit Source
8 -> 8 https://gist.github.com/sr55/9cd23c2579e545ba1fc8b8109d3375c1 (Hardware Decode)
8 -> 10 (Failed) https://gist.github.com/sr55/0b26f55e15eff89f9402653756d419cb (Software Decode)

@galad87
Copy link
Contributor Author

galad87 commented Jun 21, 2025

@sr55 could you try again if the full path nvdec 8bit -> nvenc 10bit works?

@sr55
Copy link
Contributor

sr55 commented Jun 21, 2025

Noted, I'll take a look in a bit.

@sr55
Copy link
Contributor

sr55 commented Jun 23, 2025

I'm afraid not

https://gist.github.com/sr55/8302643e5f1d6d12c432729c128b38d4

8-8 was OK

@galad87
Copy link
Contributor Author

galad87 commented Jun 23, 2025

It looks like it thinks it's not a full gpu path, so there is a wrong check somewhere.

@galad87
Copy link
Contributor Author

galad87 commented Jun 23, 2025

Maybe now? Can you try with the latest commit?

@galad87
Copy link
Contributor Author

galad87 commented Jun 23, 2025

Thanks!

@galad87 galad87 merged commit 6a42b94 into HandBrake:master Jun 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

AV1 10-bit (NVENC) 8 bit and 10 bit have exactly the same file size only in the nightly version

3 participants