-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add image sequence input (not fully merged back, Linux gui not added) #4461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…he CLI; Has repercussions for gtk,macos,win so these commits are not buildable.
| "AudioSecondaryEncoderMode": true, | ||
| "AudioTrackSelectionBehavior": "first", | ||
| "ChapterMarkers": true, | ||
| "ImageSequence": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these really be part of the preset keys?
Seems more like something that should be handled at source selection.
Ask for it up-front and maybe remember the last used framerate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, I'm not too far into the project so I don't know about this kind of choice. Feel free to do with this what you think best, I think in this case I just took the quickest route to adding the functionality this way.
|
Hello, Warning This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected. Thank You, |
|
Hello, Warning This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected. Thank You, |
|
Hello, Warning This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected. Thank You, |
|
This is probably still relevant, just nobody has time to look at it. Does that mean it's actually low priority and should be closed though? |
|
I removed the stale label which the automated system applied. That prevents closure. Indeed it would be good to implement this, but yes it is a matter of interest/time. |
Ah sorry, good to know, I won't need to keep it alive then 👍🏻 |
|
Hello, Warning This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected. Thank You, |
|
Hello, Warning This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected. Thank You, |
Description of Change:
As discussed in Issue #2346
Using the image2 demuxer, adds the option for using an image sequence as input.
Option toggle is added to macOS and Windows GUI, not yet to Gtk version.
Tested on: