Skip to content

Conversation

@sabvdf
Copy link

@sabvdf sabvdf commented Jul 19, 2022

Description of Change:

As discussed in Issue #2346
Using the image2 demuxer, adds the option for using an image sequence as input.
Option toggle is added to macOS and Windows GUI, not yet to Gtk version.

Tested on:

  • Windows 11
  • macOS 12

@bradleysepos bradleysepos requested a review from jstebbins August 7, 2022 23:32
@galad87 galad87 added this to the 1.7.0 milestone Sep 12, 2022
"AudioSecondaryEncoderMode": true,
"AudioTrackSelectionBehavior": "first",
"ChapterMarkers": true,
"ImageSequence": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these really be part of the preset keys?

Seems more like something that should be handled at source selection.

Ask for it up-front and maybe remember the last used framerate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, I'm not too far into the project so I don't know about this kind of choice. Feel free to do with this what you think best, I think in this case I just took the quickest route to adding the functionality this way.

@galad87 galad87 removed this from the 1.7.0 milestone Sep 12, 2023
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

Hello,

Warning

This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected.
If you wish this issue to remain open, please request the stale label to be removed and an appropriate label assigned.

Thank You,
The HandBrake Bot

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

Hello,

Warning

This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected.
If you wish this issue to remain open, please request the stale label to be removed and an appropriate label assigned.

Thank You,
The HandBrake Bot

@github-actions
Copy link

github-actions bot commented May 6, 2025

Hello,

Warning

This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected.
If you wish this issue to remain open, please request the stale label to be removed and an appropriate label assigned.

Thank You,
The HandBrake Bot

@sabvdf
Copy link
Author

sabvdf commented May 15, 2025

This is probably still relevant, just nobody has time to look at it. Does that mean it's actually low priority and should be closed though?

@bradleysepos
Copy link
Contributor

I removed the stale label which the automated system applied. That prevents closure.

Indeed it would be good to implement this, but yes it is a matter of interest/time.

@sabvdf
Copy link
Author

sabvdf commented May 28, 2025

I removed the stale label which the automated system applied. That prevents closure.

Ah sorry, good to know, I won't need to keep it alive then 👍🏻

@github-actions
Copy link

Hello,

Warning

This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected.
If you wish this issue to remain open, please request the stale label to be removed and an appropriate label assigned.

Thank You,
The HandBrake Bot

@github-actions
Copy link

Hello,

Warning

This pull request appears to be inactive and will be automatically closed within 10 days if no further activity is detected.
If you wish this issue to remain open, please request the stale label to be removed and an appropriate label assigned.

Thank You,
The HandBrake Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants