Feat: add tests #37
Merged
Feat: add tests #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NitBravoA92
approved these changes
Nov 10, 2023
Collaborator
NitBravoA92
left a comment
NitBravoA92
left a comment
There was a problem hiding this comment.
Status: Approved 🟢
Hi @HFG43 👋🏽
Great Job! All tests are passed correctly. You have done an excellent job throughout this project and these tests are great proof of this. I have seen your great effort. Good job!
This feature is complete, so it's time to merge it 💯 🥳.
Highlights 🥇
- No Linters errors
- Use Jest to test the React App
- Excellent job creating all the unit tests to validate the frontend app functionality
Optional suggestions
- Please Update the README file to add the Kanban Board section
Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NitBravoA92 Carmen! I'm sending this pull request for you to review my code. Thanks in advance for your feedback!
Milestones 🎯:
📌 Generate Tests for main components and Slices
📌 Generate a mock store
assets/helpers/mockStore.js🎖️ General requirements:
Gitflow
No linter errors
Ensure the use of best practices and React style