Skip to content

Conversation

@Dachrono
Copy link
Collaborator

@Dachrono Dachrono commented Nov 7, 2023

🎉 🎈 In this Milestone 🙋‍♂️ 🚩 ‼ :

Hi there 👋

  • Follow the best GitHub flow. ✅
  • Follow our list of best practices for Ruby. ✅
  • Document in a professional way. ✅
  • No linters errors. ✅
  • Create a navigation bar. ✅

To the code reviewer 👨‍💻

I really thank 🙇‍♂️ you, dear code reviewer 👨‍🎨 for dedicating your time ⌚ to check the PR 🧾 .

I kindly ask code reviewer 🤵 that if there is any issue in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions if needed.

If you think some significant issues need to be changed ♻️ please kindly contact 📞 me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

@Dachrono Dachrono requested a review from HFG43 November 7, 2023 21:57
@Dachrono Dachrono linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Owner

@HFG43 HFG43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Andy!! @Dachrono way to go! You have done an amazing job implementing this fantastic Navbar with great UX!!

It's time to merge this feature into the project!

@Dachrono Dachrono merged commit adc6c06 into dev Nov 8, 2023
@Dachrono Dachrono deleted the nav branch November 8, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.0pt] - Add Navigation Bar

3 participants