Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Compute reservation Sample #12781

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: New Compute reservation Sample #12781

wants to merge 3 commits into from
+259 −1

Conversation

Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Nov 20, 2024 •
edited
Loading

Description

Created new consume reservations Sample for doc.page

Region Tag Filename
compute_template_not_consume_reservation create_vm_template_not_consume_reservation.py

Updated tests

Checklist

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 20, 2024
@Thoughtseize1 Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 20, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 20, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 20, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Thoughtseize1 Thoughtseize1 marked this pull request as ready for review November 20, 2024 16:50
@Thoughtseize1 Thoughtseize1 requested review from a team as code owners November 20, 2024 16:50
@Thoughtseize1
Merge branch 'refs/heads/main' into vm_template_not_consume_reservation
0050bbe 
# Conflicts:
#	compute/client_library/snippets/tests/test_compute_reservation.py
@Thoughtseize1
Resolve conflicts
cde69cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thoughtseize1 @m-strzelczyk @rsamborski