Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genai): update batchprediction package #12778

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CadillacBurgess1
Copy link
Contributor

@CadillacBurgess1 CadillacBurgess1 commented Nov 19, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 19, 2024

# Example response:
# Job output location: gs://your-bucket/gen-ai-batch-prediction/prediction-model-year-month-day-hour:minute:second.12345
# View Batch Prediction Job: https://console.cloud.google.com/ai/platform/locations/us-central1/batch-predictions/12345678?project=projectid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Where is the output for Line 45's print statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Example response, just the print statement's response is enough :)

Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your work @CadillacBurgess1 👍

@holtskinner
Copy link
Contributor

@CadillacBurgess1 Why is this sample being changed to use the aiplatform library instead of vertexai?

@CadillacBurgess1 CadillacBurgess1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 21, 2024
@msampathkumar
Copy link
Member

@CadillacBurgess1 Why is this sample being changed to use the aiplatform library instead of vertexai?

Hi. We had a request to update this. @CadillacBurgess1 is working on re-confirmation. More details @ b/377035286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants