Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a new secret to build setup script #12777

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Sita04
Copy link
Collaborator

@Sita04 Sita04 commented Nov 19, 2024

Description

Add a new secret to store Cloud AI samples secrets. This secret will be setup as part of the build setup script.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 19, 2024
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@Sita04 Sita04 marked this pull request as ready for review November 19, 2024 21:35
@Sita04 Sita04 requested review from a team as code owners November 19, 2024 21:35
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@Sita04 Sita04 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 19, 2024
@holtskinner
Copy link
Contributor

Seems like the build failures aren't specific to the new file added, but every test was run since this technically affects them.

@parthea parthea removed their assignment Nov 20, 2024
@Sita04
Copy link
Collaborator Author

Sita04 commented Nov 20, 2024

@m-strzelczyk Could you help force-merge this PR please?

@m-strzelczyk m-strzelczyk merged commit 754b5a4 into main Nov 20, 2024
8 of 14 checks passed
@m-strzelczyk m-strzelczyk deleted the cloudai-samples-secrets branch November 20, 2024 16:33
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants