Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): RAG Engine - Add Create Corpus for different Vector DB #12771

Merged
merged 12 commits into from
Jan 13, 2025
Merged

docs(samples): RAG Engine - Add Create Corpus for different Vector DB #12771

merged 12 commits into from
Jan 13, 2025

Conversation

holtskinner
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@holtskinner holtskinner requested review from a team as code owners November 14, 2024 19:52
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 14, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 14, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@holtskinner holtskinner changed the title docs(samples): Add Create Corpus with Feature Store docs(samples): RAG Engine - Add Create Corpus for different Vector DB Nov 14, 2024
@glasnt glasnt removed their assignment Nov 19, 2024
@holtskinner holtskinner requested a review from a team as a code owner December 2, 2024 19:59
msampathkumar
msampathkumar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like all the tests are in place.

@msampathkumar msampathkumar merged commit 4f27ea2 into main Jan 13, 2025
13 checks passed
@msampathkumar msampathkumar deleted the rag-vector-db branch January 13, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

Assignees

@msampathkumar msampathkumar

@Sita04 Sita04

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holtskinner @msampathkumar @glasnt @Sita04