Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(genai): add prompt template example #12764

Merged
merged 8 commits into from
Nov 14, 2024
Merged

feat(genai): add prompt template example #12764

merged 8 commits into from
Nov 14, 2024

Conversation

CadillacBurgess1
Copy link
Contributor

@CadillacBurgess1 CadillacBurgess1 commented Nov 12, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 12, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 12, 2024
holtskinner
holtskinner previously requested changes Nov 12, 2024
View reviewed changes
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
matthew29tang
matthew29tang requested changes Nov 12, 2024
View reviewed changes
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
matthew29tang
matthew29tang requested changes Nov 14, 2024
View reviewed changes
generative_ai/prompts/test_prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
generative_ai/prompts/prompt_template.py Outdated Show resolved Hide resolved
@CadillacBurgess1 CadillacBurgess1 dismissed holtskinner’s stale review November 14, 2024 23:26

Thanks Holt. This has been addressed with Matthew

@CadillacBurgess1 CadillacBurgess1 merged commit f5e51eb into GoogleCloudPlatform:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew29tang matthew29tang matthew29tang approved these changes

@msampathkumar msampathkumar msampathkumar approved these changes

@Sita04 Sita04 Awaiting requested review from Sita04

@holtskinner holtskinner Awaiting requested review from holtskinner

Assignees

@nicain nicain

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CadillacBurgess1 @msampathkumar @holtskinner @matthew29tang @nicain