fix: sqlalchemy dependencies #12760
Open
fix: sqlalchemy dependencies #12760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLAlchemy v2.0.24 fails with Python 3.13 with error:
```
AssertionError: Class <class 'sqlalchemy.sql.elements.SQLCoreOperations'> directly inherits TypingOnly but has additional attributes {'__static_attributes__'}.
```
[see bug GoogleCloudPlatform#11334](sqlalchemy/sqlalchemy#11334)
Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid
such problems in the future.
product-auto-label
bot
added
samples
|
@wiktorn wouldn't MySQL and SQL Server folders also benefit from this change? MySQL: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/cloud-sql/mysql/sqlalchemy |
|
@jackwotherspoon Actually, both MySQL and SQL Server pinned python:3.11 (though different flavors). I aligned Dockerfiles and requirements.txt across these three. |
iennae
reviewed
Nov 21, 2024
iennae
reviewed
Nov 21, 2024
iennae
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQLAlchemy v2.0.24 fails with Python 3.13 with error:
see bug #11334
Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid such problems in the future.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)