Skip to content

feat: New Compute Sample - Consume single project reservation #12750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Thoughtseize1 merged 5 commits into from
Nov 14, 2024
Merged

feat: New Compute Sample - Consume single project reservation #12750

Thoughtseize1 merged 5 commits into from
Nov 14, 2024

Conversation

@Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Nov 5, 2024 •
edited
Loading

Description

🔶 Created new Compute Samples for Doc.page

  • Consume a specific single-project reservation.
  • Consume a specific shared project reservation.
  • Consume a any project reservation.
Region tag Filename
compute_consume_single_project_reservation /compute_reservations/consume_single_project_reservation.py
compute_consume_any_matching_reservation /compute_reservations/consume_any_project_reservation.py
compute_consume_specific_shared_reservation /compute_reservations/consume_specific_shared_reservation.py

👀 Refactored compute_reservation/create_compute_reservation.py -> deleted specific_reservation_required parameter to implement it in new created file.

Checklist

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 5, 2024
@Thoughtseize1 Thoughtseize1 added the snippet-bot:force-run Force snippet-bot runs its logic label Nov 5, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 5, 2024
@snippet-bot
Copy link

snippet-bot bot commented Nov 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Thoughtseize1 Thoughtseize1 marked this pull request as ready for review November 5, 2024 15:24
@Thoughtseize1 Thoughtseize1 requested review from a team as code owners November 5, 2024 15:24
@Thoughtseize1 Thoughtseize1 merged commit 0cf659a into main Nov 14, 2024
14 checks passed
@Thoughtseize1 Thoughtseize1 deleted the consume_single_project_reservation branch November 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thoughtseize1 @m-strzelczyk @rsamborski