feat(dataplex): add code samples for Aspect Types #12738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 30, 2024 16:37
product-auto-label
bot
added
api: dataplex
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
jacspa96
commented
Oct 30, 2024
m-strzelczyk
requested changes
Nov 4, 2024
Comment on lines
71
to
79
| aspect_type = create_aspect_type.create_aspect_type( | ||
| PROJECT_ID, LOCATION, aspect_type_id_to_create, [] | ||
| ) | ||
| # Clean-up created Aspect Type | ||
| delete_aspect_type.delete_aspect_type( | ||
| PROJECT_ID, LOCATION, aspect_type_id_to_create | ||
| ) | ||
|
|
||
| assert expected_aspect_type_to_create == aspect_type.name |
There was a problem hiding this comment.
We usually do it like:
try:
create()
assert
finally:
delete()
m-strzelczyk
approved these changes
Nov 4, 2024
Co-authored-by: Maciej Strzelczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/368503059
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)