-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(genai): add Gemini batch prediction samples for BQ and GCS #12731
feat(genai): add Gemini batch prediction samples for BQ and GCS #12731
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. can use minor refinements. Added all the suggestion in commit-able messages. PTAL.
|
||
# Initialize vertexai | ||
vertexai.init(project=PROJECT_ID, location="us-central1") | ||
|
||
input_uri = "gs://cloud-samples-data/batch/prompt_for_batch_gemini_predict.jsonl" | ||
# Sample filedata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the documentation page already has examples for input and output. It's redundant to put the examples in the code samples. Plus, the examples are not accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
Update: I have been waiting for this new samples for too long. CICD tests are passing and code samples LGTM. So approved and merged. @CadillacBurgess1 - Kindly discuss with others and raise a new PR for any changes you wish to add. Thank you for your work 👍 |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)