Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genai): add Gemini batch prediction samples for BQ and GCS #12731

Merged
merged 16 commits into from
Oct 31, 2024

Conversation

CadillacBurgess1
Copy link
Contributor

@CadillacBurgess1 CadillacBurgess1 commented Oct 28, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@CadillacBurgess1 CadillacBurgess1 requested review from a team as code owners October 28, 2024 12:00
Copy link

snippet-bot bot commented Oct 28, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 28, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can use minor refinements. Added all the suggestion in commit-able messages. PTAL.

generative_ai/batch_predict/gemini_batch_predict_gcs.py Outdated Show resolved Hide resolved
generative_ai/batch_predict/gemini_batch_predict_gcs.py Outdated Show resolved Hide resolved

# Initialize vertexai
vertexai.init(project=PROJECT_ID, location="us-central1")

input_uri = "gs://cloud-samples-data/batch/prompt_for_batch_gemini_predict.jsonl"
# Sample filedata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the documentation page already has examples for input and output. It's redundant to put the examples in the code samples. Plus, the examples are not accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@msampathkumar msampathkumar merged commit bf57460 into GoogleCloudPlatform:main Oct 31, 2024
11 checks passed
@msampathkumar
Copy link
Member

Update: I have been waiting for this new samples for too long. CICD tests are passing and code samples LGTM. So approved and merged.

@CadillacBurgess1 - Kindly discuss with others and raise a new PR for any changes you wish to add. Thank you for your work 👍

@msampathkumar msampathkumar self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants