Update poll.js to include XML Header in fetch request #12544
Conversation
product-auto-label
bot
added
samples
iennae
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
How do we close this PR? @jinglundong |
|
I approved the PR. Let's wait for the Kokoro CI results. |
|
I just clicked re-run all checks to see if those Kokoro CI can be completed. |
|
I don't know why the Kokoro CIs are not triggered. We may need approval from iennae, the other reviewer, as well. |
iennae
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
|
3 tests/checks failed. Could you please take a look and ideally fix them? Thanks! |
|
@jinglundong I cant view the build results it says permisson denied. Im wondering if the linter is failing because its a js file with the python linter? |
|
@jinglundong I rerean the linter and it passes for some python. nox > * py-2.7: failed What i dont understand is if the js file is ever going to pass a python linter? I dont know why this file is in this repository. |
|
@kennethye1 At first glance, I was wondering if these integration tests failed due to the lifecycle policy enforcement. However, python-3.8 succeeded but python-3.11 failed. Are they really testing the modernized path? Edit: seems like we are testing the modernized path. https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fpython-docs-samples+ubuntu22&type=code, but we aren't really testing specific python minor versions from what I'm reading. |
|
@SandeepTuniki Could you help triage this PR? |
harisam@ is looking into this PR. |
…atform#12668) * Added compute_reservation_from_vm Sample
…dPlatform#12629) * Add new code samples * Add minor code refactoring & improving visibility
…12656) * chore(deps): update dependency pyyaml to v6.0.2 * remove --temp-location --------- Co-authored-by: David Cavazos <[email protected]>
* fix typo in sample file name * update test file * refresh CI checks
…#12557) * fix(gae): resolve linting issues in main_test.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: resolve linting issues where pytest not available for python versions * add requirement six --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: David Cavazos <[email protected]>
* chore(oss): correct apache license headers * lint
…tform#12644) * Reorganized Video Samples
…leCloudPlatform#12673) * Refactored "Text Generation" Category * Refactored Text Generation files * Moved openAI Samples
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Description
Fixes b/362304568
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)