Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tpu_vm_create/get/list/delete/stop/start #3893

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: tpu_vm_create/get/list/delete/stop/start #3893

wants to merge 9 commits into from
+658 −0

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Oct 3, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Oct 3, 2024
@gryczj gryczj force-pushed the tpu_vm_create branch 3 times, most recently from f834bd5 to d806047 Compare October 4, 2024 10:11
@gryczj gryczj marked this pull request as ready for review October 4, 2024 10:12
@gryczj gryczj requested review from a team as code owners October 4, 2024 10:12
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Oct 4, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj marked this pull request as draft October 4, 2024 10:31
@gryczj gryczj changed the title feat: tpu_vm_create feat: tpu_vm_create/get/list/delete Oct 4, 2024
@gryczj gryczj marked this pull request as ready for review October 4, 2024 17:40
@gryczj gryczj marked this pull request as draft October 4, 2024 19:07
subfuzion
subfuzion approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending test issues

@gryczj gryczj force-pushed the tpu_vm_create branch 15 times, most recently from 7395f78 to 1edb149 Compare October 9, 2024 18:48
@gryczj gryczj force-pushed the tpu_vm_create branch 11 times, most recently from 41d812a to b890169 Compare October 31, 2024 09:52
@gryczj gryczj marked this pull request as draft November 12, 2024 09:13
@gryczj gryczj marked this pull request as ready for review November 12, 2024 11:24
@gryczj
Copy link
Contributor Author

gryczj commented Nov 12, 2024

Due to high costs of TPU Nodes, it was decided to use mocks in the tests.

@gryczj gryczj force-pushed the tpu_vm_create branch 2 times, most recently from b21ff7e to bdea623 Compare November 21, 2024 08:47
@gryczj gryczj requested a review from iennae November 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion Awaiting requested review from subfuzion

@iennae iennae Awaiting requested review from iennae

Assignees
No one assigned
Labels
api: tpu Issues related to the Cloud TPU API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gryczj @m-strzelczyk @subfuzion @kokoro-team