Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_alternatives.sh script #627

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Improve test_alternatives.sh script #627

merged 2 commits into from
Mar 11, 2021

Conversation

paulmoon
Copy link
Contributor

Improvements:

  • Create functions for each DM/TF/KRM provisioning resources
  • Don't require the user to login if we can detect that valid creds exist
  • Colorize the success and failure messages
  • Use only one project instead of requiring 3 different projects
  • Clean up the resources after provisioning resources
  • Fix a few bugs here and there, like
    • cp -R alternatives/krm should be cp -R alternatives/krm/, and same for Terraform
    • Add 60s timeout for waiting for PubSubSubscription
  • Change deployment name from d1 to deployment to be slightly more descriptive

If this PR looks good, I'll make similar changes to the other existing test_alternatives.sh script. This should make future test_alternatives.sh script better.

@google-cla
Copy link

google-cla bot commented Mar 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…ints, and not requiring the user to login if the credentials already exist

Author:    Paul Moon <[email protected]>
@google-cla
Copy link

google-cla bot commented Mar 10, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Mar 11, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants