Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pubsub.jinja's type to use gcp-types #626

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Update pubsub.jinja's type to use gcp-types #626

merged 1 commit into from
Mar 9, 2021

Conversation

paulmoon
Copy link
Contributor

@paulmoon paulmoon commented Mar 9, 2021

No description provided.

@paulmoon paulmoon requested a review from KevinEmery March 9, 2021 00:25
@google-cla
Copy link

google-cla bot commented Mar 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

KevinEmery
KevinEmery approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@KevinEmery KevinEmery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-cla
Copy link

google-cla bot commented Mar 9, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Mar 9, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@paulmoon paulmoon merged commit f91b30a into GoogleCloudPlatform:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinEmery KevinEmery KevinEmery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmoon @googlebot @KevinEmery