Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pubsub KRM files #625

Merged
merged 23 commits into from
Mar 10, 2021
Merged

Add pubsub KRM files #625

merged 23 commits into from
Mar 10, 2021

Conversation

NamrataShah5
Copy link
Collaborator

No description provided.

Doooritooos
Doooritooos reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@Doooritooos Doooritooos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Thank you for adding the KRM files.

paulmoon
paulmoon suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@paulmoon paulmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, just a few comments.

google/resource-snippets/pubsub-v1/test_alternatives.sh Outdated Show resolved Hide resolved
google/resource-snippets/pubsub-v1/test_alternatives.sh Outdated Show resolved Hide resolved
google/resource-snippets/pubsub-v1/alternatives/krm/pubsub.yaml Show resolved Hide resolved
google/resource-snippets/pubsub-v1/alternatives/krm/Kptfile Outdated Show resolved Hide resolved
paulmoon
paulmoon suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@paulmoon paulmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments, this should be the last round of comments though.

google/resource-snippets/pubsub-v1/alternatives/krm/pubsub.yaml Outdated Show resolved Hide resolved
google/resource-snippets/pubsub-v1/test_alternatives.sh Show resolved Hide resolved
google/resource-snippets/pubsub-v1/test_alternatives.sh Outdated Show resolved Hide resolved
@NamrataShah5 NamrataShah5 merged commit 3346e6d into master Mar 10, 2021
@NamrataShah5 NamrataShah5 deleted the pubsub-krm branch March 10, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doooritooos Doooritooos Doooritooos left review comments

@paulmoon paulmoon paulmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NamrataShah5 @paulmoon @Doooritooos