Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Manager - Full Production [ACE] - nodejs.py #623

Conversation

akshaykumarpatil-tudip
Copy link
Contributor

  • Updated the below changes in nodejs.py file as necessary.
  1. Changed the port back to MySQL default i.e. 3306
  2. Added MySQL Docker environment vars for the MYSQL_ROOT_PASSWORD
  3. Updated gcr.io/qwiklabs-resources/mysql
  4. Updated gcr.io/qwiklabs-resources/nodejsservice
  5. Updated the maxSize with 20. (As we have instructions in lab to update it with 4)

- Updated the below changes in nodejs.py file as necessary.
- Changed the port back to MySQL default i.e. 3306
- Added MySQL Docker environment vars for the MYSQL_ROOT_PASSWORD
- Updated gcr.io/qwiklabs-resources/mysql
- Updated gcr.io/qwiklabs-resources/nodejsservice
- Updated the maxSize with 20. (As we have instructions in lab to update it with 4)
@akedin akedin self-requested a review March 4, 2021 19:22
Copy link
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akedin akedin merged commit 23b38cf into GoogleCloudPlatform:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants