Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudkms krm #622

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Add cloudkms krm #622

merged 2 commits into from
Mar 5, 2021

Conversation

azhao155
Copy link
Collaborator

@azhao155 azhao155 commented Mar 3, 2021

Add cloudkms krm

@azhao155 azhao155 requested a review from paulmoon March 3, 2021 19:12
paulmoon
paulmoon suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@paulmoon paulmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of comments.

google/resource-snippets/cloudkms-v1/alternatives/krm/Kptfile Outdated Show resolved Hide resolved
google/resource-snippets/cloudkms-v1/alternatives/krm/Kptfile Outdated Show resolved Hide resolved
google/resource-snippets/cloudkms-v1/alternatives/krm/cloudkms.yaml Outdated Show resolved Hide resolved
@azhao155 azhao155 merged commit 2849d67 into GoogleCloudPlatform:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doooritooos Doooritooos Doooritooos left review comments

@andrei-scripniciuc andrei-scripniciuc andrei-scripniciuc approved these changes

@paulmoon paulmoon paulmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azhao155 @paulmoon @Doooritooos @andrei-scripniciuc