Add TF config/testing script for cloudkms #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmoon
suggested changes
Feb 17, 2021
google/resource-snippets/cloudkms-v1/alternatives/tf/cloudkms.tf
Outdated
Show resolved
Hide resolved
google/resource-snippets/cloudkms-v1/alternatives/tf/cloudkms.tf
Outdated
Show resolved
Hide resolved
Thanks for the review, have addressed the comments, please take a look! |
paulmoon
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to add TF alternatives for CloudKms snippets.
See go/dm-snippets-alternatives for objective and background
Adding readme to show how to launch each of the tools
Adding tf directories with configs
Adding test_alternatives.sh intended to run manually