Add cloud nat template #429
Conversation
| resources = [ | ||
| { | ||
| 'name': context.env['name'], | ||
| # compute.v1.router seems to be doing the job though |
There was a problem hiding this comment.
https://cloud.google.com/compute/docs/reference/rest/v1/routers Managed NAT got GA, so itś part of compute.v1
| 'name': context.env['name'], | ||
| # compute.v1.router seems to be doing the job though | ||
| # doc says compute.beta has the NAT feature. | ||
| 'type': 'compute.v1.router', |
There was a problem hiding this comment.
Can you please use gcp-types/compute-v1:routers as type, we are moving towards the GCP types.
| [[ "$output" =~ "udpIdleTimeoutSec: 55" ]] | ||
| [[ "$output" =~ "/regions/us-east1/addresses/ip-${RAND}" ]] | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you please add the test from HA NAT which actually creates an pivate instance and able to reach the internet?
There was a problem hiding this comment.
do you mean the same as this test?
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/tree/master/community/cloud-foundation/templates/nat_gateway
There was a problem hiding this comment.
Yes, I would be happy to see an instance using the managed NAT ( and maybe one not using it) and verifying it's internet connectivity via SSH.
|
@sourced-nan Will you have a chance to incorporate Adam's feedback? |
Cloud nat template for native nat service