[hue] update action for July 2024 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: hue/README.md * line-wrapped and clarified important note modified: hue/hue.sh * added functions os_id, is_debian, is_debian10, is_ubuntu * only adding buster-backports to sources.list for debian10 * update_repo now uses is_debian || is_ubuntu rather than checking for apt-get in path * setting DEBIAN_FRONTEND=noninteractive before installation of hue ; mysql-community-server had an important message that it was prompting the user to answer on a non-interactive console, halting tests. * added note that we may need to specify this option with debconf * jettisoned my function remove_old_backports with preference for Prince's much better replace_backports_repo * using slightly different logic to determine whether we replace the backports repo
|
/gcbrun |
|
/gcbrun |
|
The previous run didn't seem to get the message that the installation was noninteractive and stopped again with the following prompt. I do not see this behavior in my reproduction environment. |
|
last test revealed that I had failed to define os_version on which is_debian depends. This should fix that last failure. |
|
/gcbrun |
|
@prince-cs - this PR is ready for squash and merge. I believe i granted you authorization to perform reviews. Please review and approve if you believe we're ready to push this one out. I know that #1192 is blocked on hue and probably others. |
prince-cs
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: hue/README.md
modified: hue/hue.sh
added functions os_id, is_debian, is_debian10, is_ubuntu
only adding buster-backports to sources.list for debian10
update_repo now uses is_debian || is_ubuntu rather than checking for apt-get in path
setting DEBIAN_FRONTEND=noninteractive before installation of hue ; mysql-community-server had an important message that it was prompting the user to answer on a non-interactive console, halting tests.
added note that we may need to specify this option with debconf
jettisoned my function remove_old_backports with preference for Prince's much better replace_backports_repo
using slightly different logic to determine whether we replace the backports repo