-
Notifications
You must be signed in to change notification settings - Fork 515
[rapids] bringing action up to date #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* adding functions to check running environment OS * set rapids version to 23.12 * set cuda version to 11.8 * set cudf version - is this version used? * set xgboost version to 2.0.3 * created variable to store scala version * setting python_ver by operating system
* added functions to check for ubuntu variants * removed definitions of unused variables having to do with CUDF * capping max version for CUDA_VERSION to 11.8 which 12.4 implements probably * capping max version of python to 3.10 until the stack works with python 3.11
|
Manually tested on
|
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
this may depend on #1200 since I developed those changes as I was exercising these manual test runs. |
|
https://github.com/GoogleCloudDataproc/initialization-actions/blob/master/rapids/test_rapids.py#L98 The presubmits seems to be failing because of this. |
|
Also the timeout for presubmits needs to be increase to at least 4 hours. |
| readonly DEFAULT_CUDF_VERSION="22.10.0" | ||
| readonly DEFAULT_XGBOOST_VERSION="1.6.2" | ||
| readonly DEFAULT_XGBOOST_GPU_SUB_VERSION="0.3.0" | ||
| readonly DEFAULT_CUDA_VERSION="11.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In GPU Driver we set the default cuda version to be 12.4. But, here it is 11.8. Any specific reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.8 is the maximum supported by mamba package, 'cudatools', which is ultimately the goal of this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line no. 99: metadata is not required and is also not defined. Therefore, breaking the test flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is required and must have been left out in a previous commit. fixed maybe. I'll gcbrun to see.
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
rapids/test_rapids.py
Outdated
| if self.getImageOs() == 'rocky': | ||
| self.skipTest("Not supported in Rocky Linux-based images") | ||
| # if self.getImageOs() == 'rocky': | ||
| # self.skipTest("Not supported in Rocky Linux-based images") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please just delete these.
rapids/test_rapids.py
Outdated
| def test_rapids_spark(self, configuration, machine_suffixes, accelerator): | ||
| if self.getImageOs() == 'rocky': | ||
| self.skipTest("Not supported in Rocky Linux-based images") | ||
| # if self.getImageOs() == 'rocky': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
rapids/test_rapids.py
Outdated
|
|
||
| if self.getImageOs() == 'rocky': | ||
| self.skipTest("Not supported in Rocky Linux-based images") | ||
| # if self.getImageOs() == 'rocky': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Uh oh!
There was an error while loading. Please reload this page.