cc @naarok

Provided changes suggested by @crpahl are done, I'm good with this.

@naarok Some specs were broken which @daiaventureira fixed as part of this PR. Any concerns with these changes? Also, is there anything else we should test other than running specs?

And to release a new version after this is merged, I'm guessing we still follow this?

To release a new version, update the version number in version.rb, and then run bundle exec rake release, which will create a git tag for the version, push git commits and tags, and push the .gem file to rubygems.org.

@crpahl hmm. This code is actually in an interim state between old way and rewrite. I’m gonna have to think about how to deploy a bit. I’ll make sure that happens tomorrow.

in fact it is probably best for me to take over completing this PR as well. I have time tomorrow for that.

@naarok Okay sounds good. Thanks John!

@daiaventureira @crpahl Happily, the code on master was in better state than I feared (except for those broken specs. Thanks for fixing them @daiaventureira )

As an FYI, those instructions for doing a new release were just from the generated template and not valid for this library as it is not pushed to RubyGems. I've removed them.

A new release requires us to bump the version number in this repo (and update the changelog). A 2nd PR will need to be done in JO to update the library there. I'll do that and pass on to you for review.