Clean up redirect IDs & forwarding logic #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
We should maybe gate these changes behind a query parameter. This will allow us to deploy this change & confidently validate that the new logic does not regress the existing redirects, before effecting 100% of redirects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up the logic for our redirects.
The main change is a fairly low-risk refactor. Instead of two separate arrays and needing to ensure you don't end up off-by-one, we can instead use a hash and use
Object.keys()andObject.values()to compose the resulting arrays.The second commit updates the redirect logic to instead look at the final segment of the URL to find the ID, instead of looping through every ID and then
.indexOf()-ing the URL. This reduces the time complexity of the lookup and should make all redirects equally fast. Right now, later redirects take longer to perform due to looping through the older redirects first.