feat: ListBox => ListView #1301
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess I'm really not meant to take a break from Tuba...
Anyway, ListView is the 1.0.0 blocker. This is yet another retry. Memory wise, it works. No matter how many posts you scroll down it will always be < 200 MB.
But that's because it patches GTK to limit it to 20 items recycler. We need to make our own one.
Main loop blocking wise, I did yet another round of profiling, the main things I can see is actions and binding. Obviously this still uses our messy binding and I don't think we will ever get over it, but we can at least try and do our best to optimize it. Moving away from GtkBuilder for status widgets might also help slightly. If we know that a timeline will only have a certain type of widgets we could attempt to optimize it further.