-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Deprecate 'keepends' argument in favor of 'drop' #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate 'keepends' argument in favor of 'drop' #2476
Conversation
88af217 to
b9dca8c
Compare
b9dca8c to
2bede6a
Compare
2bede6a to
8d10734
Compare
c9c6174 to
58ce74e
Compare
832280c to
3e1225b
Compare
|
I have like 30 emails from failing pipeline in my inbox. xd |
d0ea491 to
ddef6b3
Compare
|
When inserting the It's annoying but we can switch the order when doing a major version bump. What do you think @Arusekk ? |
|
@peace-maker I agree we should start working on Pwntools 5 soon, dropping py2, adding type annotations, and cleaning up dependencies, inconsistent interfaces and useless defaults. |
|
@peace-maker I was thing of just removing keepends altogether. |
ddef6b3 to
e4d6666
Compare
Add 'drop' argument in place of 'keepends' for tubes. 'keepends' still works but raises depreciation warning.
e4d6666 to
ee59abc
Compare
That was resolved. |
Add 'drop' argument in place of 'keepends' for tubes. 'keepends' still works but raises depreciation warning.
Resolves #2258.