Skip to content

Conversation

@beckermr
Copy link
Collaborator

@beckermr beckermr commented Sep 13, 2024

This PR adds 1d integration via quadax.

closes #66

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #118 will degrade performances by 30.76%

Comparing int1d (fcca8d6) with main (746975b)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main int1d Change
test_benchmarks_lanczos_interp[kval-conserve_dc-run] 447.3 µs 646.1 µs -30.76%
test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 646.3 µs 447.6 µs +44.39%


<!-- start-api-coverage -->
JAX-GalSim has implemented 22.6% of the GalSim API. See the list below for the supported APIs.
JAX-GalSim has implemented 22.5% of the GalSim API. See the list below for the supported APIs.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug in how we count APIs means this dropped even though I added APIs. 🤦‍♂️

@beckermr beckermr marked this pull request as ready for review September 14, 2024 09:27
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckermr beckermr merged commit 3a0ffcb into main Sep 15, 2024
@beckermr beckermr deleted the int1d branch September 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moffat tests to be activated

3 participants